Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4: timestamp field #38

Merged
merged 8 commits into from
Dec 28, 2023
Merged

Issue #4: timestamp field #38

merged 8 commits into from
Dec 28, 2023

Conversation

idrissneumann
Copy link
Collaborator

No description provided.

@idrissneumann idrissneumann changed the title Issue #37: add todos Issue #4: tie Dec 8, 2023
@idrissneumann idrissneumann changed the title Issue #4: tie Issue #4: timestamp field Dec 8, 2023
@idrissneumann
Copy link
Collaborator Author

idrissneumann commented Dec 8, 2023

At this stage, the fields have been removed from the configuration but we get a 500 error when saving the datasource:

Screenshot 2023-12-08 at 17 03 50
grafana-quickwit-datasource  | logger=context userId=1 orgId=1 uname=admin t=2023-12-08T16:03:20.796039756Z level=error msg="Failed to call resource" error="failed to receive call resource response: rpc error: code = Unknown desc = timeField cannot be cast to string" traceID=
grafana-quickwit-datasource  | logger=context userId=1 orgId=1 uname=admin t=2023-12-08T16:03:20.796109172Z level=error msg="Request Completed" method=GET path=/api/datasources/uid/de409a66-8a71-46d9-8977-683699933660/resources/indexes/yoi status=500 remote_addr=192.168.247.1 time_ms=14 duration=14.25399ms size=184 referer=http://localhost:3000/connections/datasources/edit/de409a66-8a71-46d9-8977-683699933660 handler=/api/datasources/uid/:uid/resources/*
Screenshot 2023-12-08 at 17 05 29

We need to proxify the /describe endpoint from quickwit in the datasource backend.

@idrissneumann idrissneumann force-pushed the feat_timestamp_field branch 2 times, most recently from 6ef8e3f to cd95e27 Compare December 9, 2023 09:44
@idrissneumann idrissneumann reopened this Dec 12, 2023
@idrissneumann idrissneumann force-pushed the feat_timestamp_field branch 2 times, most recently from fbd2a64 to 9834af7 Compare December 14, 2023 09:47
@idrissneumann
Copy link
Collaborator Author

At this stage, seems ok:

Screenshot 2023-12-14 at 10 46 04

Will test if there's some regression on the search

@idrissneumann
Copy link
Collaborator Author

Regressions tests ok:

Screenshot 2023-12-14 at 11 07 52

@idrissneumann idrissneumann marked this pull request as ready for review December 14, 2023 10:10
@idrissneumann idrissneumann force-pushed the feat_timestamp_field branch 2 times, most recently from 4e7a873 to 376441f Compare December 14, 2023 16:53
@fmassot
Copy link
Contributor

fmassot commented Dec 15, 2023

I get a 500 if the index does not exist
Screenshot from 2023-12-15 15-33-32

@idrissneumann
Copy link
Collaborator Author

idrissneumann commented Dec 16, 2023

I get a 500 if the index does not exist !

@fmassot It's fixed with 022d331

Screenshot 2023-12-16 at 13 55 16

@idrissneumann idrissneumann force-pushed the feat_timestamp_field branch 2 times, most recently from dc51b84 to 2141af1 Compare December 16, 2023 13:05
pkg/quickwit/quickwit.go Outdated Show resolved Hide resolved
@idrissneumann idrissneumann force-pushed the feat_timestamp_field branch 2 times, most recently from c2e2ff4 to 89226d0 Compare December 22, 2023 14:34
Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good, I did not find issues while testing it.

Can we add a few tests on the backend side? This will really help to sleep at night :)

@idrissneumann
Copy link
Collaborator Author

Can we add a few tests on the backend side? This will really help to sleep at night :)

It's done :)

@idrissneumann
Copy link
Collaborator Author

Last status check, still working great:

Screenshot 2023-12-28 at 13 11 44
grafana-quickwit-datasource  | logger=plugin.quickwit-quickwit-datasource t=2023-12-28T12:11:07.21707582Z level=info msg="Calling quickwit endpoint: http://host.docker.internal:7280/api/v1/indexes/yoii"
grafana-quickwit-datasource  | logger=plugin.quickwit-quickwit-datasource t=2023-12-28T12:11:07.633917111Z level=info msg="Found timestampFieldName = yo.timestamp, timestampFieldFormat = rfc3339"

@idrissneumann idrissneumann merged commit 0be5213 into main Dec 28, 2023
2 checks passed
@guilload guilload deleted the feat_timestamp_field branch March 12, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants