-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #20: add dynamic fields #41
Conversation
0e9705d
to
881e3e9
Compare
881e3e9
to
f3b7750
Compare
@fmassot At this stage, seems working: I add a filter on $ curl http://localhost:7280/api/v1/_elastic/yoi/_field_caps
{
"indices": [
"yoi"
],
"fields": {
"timestamp": {
"date_nanos": {
"metadata_field": false,
"searchable": true,
"aggregatable": true,
"type": "date_nanos",
"indices": [
"yoi"
]
}
},
"yo": {
"text": {
"metadata_field": false,
"searchable": true,
"aggregatable": false,
"type": "text",
"indices": [
"yoi"
]
},
"keyword": {
"metadata_field": false,
"searchable": true,
"aggregatable": false,
"type": "keyword",
"indices": [
"yoi"
]
}
},
"_field_presence": {
"long": {
"metadata_field": false,
"searchable": true,
"aggregatable": false,
"type": "long",
"indices": [
"yoi"
]
}
}
}
} |
@idrissneumann I declared explicit types for field capabilities, can you check my last modifications? |
…ode is incompatible with port_bindings
Yeah, nice refactoring, it's a better version with explicit types for sure. I made two changes:
The tests are still ok though so LGTM for me :) |
89ce47f
to
debd8ae
Compare
No description provided.