Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log limits UX : select log end & raised limit #97

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

ddelemeny
Copy link
Collaborator

Issues #88 & #89 showcase bad UX of the current log query limit.

  • Grafana's pagination components may fail up to v10.3, v10.4 should fix issues with the "older logs" button not working
    -> Won't fix, wait for next release, maybe document the issue ?

  • Timestamp resolution matters, as grafana paginates on timestamp only and at the moment doesn't provide any hint about the data already fetched when issuing a page query. Too many records with the same timestamp will cause data to be skipped between pages. If this issue arises, using a finer timestamp resolution and raised query limits are the solution.
    -> Raise default query limits to 1000, partially fixes Make sure older logs can be explored #88 ?

  • Chronological exploration of logs is a use case where the limit can cause frustration, because the current behavior only returns the log tail.
    -> Add a query setting to allow querying the log head (within the defined time range), fixes Add sort direction #89

Bonus refactoring

QueryEditorSpecialMetricRow and QueryEditorRow shared the same layout code, rename and refactor.

@ddelemeny
Copy link
Collaborator Author

Possible follow ups

  • Configurable query defaults : I think it would be nice to allow users to tailor the default fragments used to initialize a query to their use-case. This would require substantial modifications to the query editor initialization, and a dedicated UX.
  • Make the consequences of limits louder : find a way to alert the user of the possible log-skipping consequences of query limits and recommended workarounds

@fmassot fmassot merged commit d4ddf3a into main Mar 10, 2024
2 checks passed
@ddelemeny ddelemeny deleted the ddelemeny/log-end-selector branch March 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sort direction Make sure older logs can be explored
2 participants