Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create lambda infrastructure #3830
Create lambda infrastructure #3830
Changes from all commits
3a63198
d664fc0
6c341bf
3f3f3f7
5c2e952
66ba136
54e3681
e2783be
682c556
b232014
98c3adb
eeae737
e396479
ad7303d
aedf6b6
78da294
42e94d7
190ea51
8924e8b
a69a24c
1f2e581
d6def90
0bd898e
b8e577e
23eaa9f
230e2b2
44f0883
1f7ab02
e4ca468
ceeb6cc
cede7c5
3df2583
581b703
7073480
7c462d3
448d9cd
ca8434f
1780671
8e769d5
2566aa1
d6255fb
81b2267
77cb5d3
a1e5db1
fd0ffa2
79b7f8d
daffc47
b7baa3d
aee6bd0
3c4aedb
8d1bc2e
b697f44
6550b56
10f90e7
7463436
698f6e5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving the benchmark scripts as part of the code base. We might want to remove them to avoid clutter and improve readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, after playing a bit with cdk, I think the best is to keep in the repository only the stuff related to the build of the binaries and move everything else in a dedicated repository.
We can do this cleanup just after the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This README somewhat overlaps with the tutorial but goes more in depth. I would argue this redundancy is fine despite the maintenance burden.