Fix nightly builds #3950
Merged
Fix nightly builds #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guilload I am not 100% sure about this fix, but tried to run it and the frontend builds went through: https://github.com/quickwit-oss/quickwit/actions/runs/6498384922/job/17649604209. I propose we merge this and see if the nightly passes tonight (and the nights after 😄). |
guilload
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are still having errors in the frontend build in the nightly CI after #3877.
From the logs, it seems
node-gypis not installed. Even though yarn seems to install it automatically, when we compare the logs of various runs, it seems that it does so in parallel, and there might be some race condition there that would explain the transient failures. Eagerly installingnode-gypmight help.How was this PR tested?
Describe how you tested this PR.