Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix force commit on ingest V2 #5350

Merged
merged 19 commits into from
Sep 2, 2024
Merged

Fix force commit on ingest V2 #5350

merged 19 commits into from
Sep 2, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Aug 27, 2024 •
edited
Loading

Description

Closes #4438

  • fix bug in the CommitType serde
  • add mechanism to wait using EventBroker
  • add tests at the workbench level
  • add elasticsearch tests for refresh param
  • disable ingest timeout when waiting for commit

How was this PR tested?

Describe how you tested this PR.

@rdettai rdettai self-assigned this Aug 27, 2024
@rdettai rdettai linked an issue Aug 27, 2024 that may be closed by this pull request
Ingest V2 misses commit force #4438
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

On SSD:

Average search latency is 1.0x that of the reference (lower is better).
Ref run id: 3170, ref commit: 34a162f
Link

On GCS:

Average search latency is 0.962x that of the reference (lower is better).
Ref run id: 3171, ref commit: 34a162f
Link

@rdettai rdettai marked this pull request as ready for review August 27, 2024 12:30
@rdettai rdettai requested a review from trinity-1686a August 27, 2024 12:30
@rdettai rdettai mentioned this pull request Aug 28, 2024
Closed
@rdettai rdettai removed the request for review from trinity-1686a August 28, 2024 15:56
@rdettai rdettai force-pushed the flaky-integ-tests branch from 49fd9bf to 152c714 Compare August 29, 2024 11:30
@rdettai rdettai force-pushed the fix-commit-force branch 2 times, most recently from 54bfb53 to 543c84c Compare August 29, 2024 13:01
@rdettai rdettai requested a review from fulmicoton August 29, 2024 14:47
fulmicoton
fulmicoton requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@fulmicoton fulmicoton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdettai I think there is a bug if the required position arrives after the position notification.
(apologies if I am wrong)

@rdettai rdettai force-pushed the flaky-integ-tests branch from 2292bdd to 066cc3f Compare August 30, 2024 07:23
@rdettai rdettai force-pushed the fix-commit-force branch 2 times, most recently from 34dd452 to fbbdc0f Compare August 30, 2024 08:42
Base automatically changed from flaky-integ-tests to main September 2, 2024 12:27
@rdettai rdettai enabled auto-merge (rebase) September 2, 2024 12:57
@rdettai rdettai merged commit 7cfc733 into main Sep 2, 2024
5 checks passed
@rdettai rdettai deleted the fix-commit-force branch September 2, 2024 13:24
@rdettai
Copy link
Contributor Author

rdettai commented Sep 2, 2024

sorry, I meant to squash these commits before merging, sorry for flooding the main branch!

@rdettai rdettai mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton fulmicoton approved these changes

Assignees

@rdettai rdettai

Labels
None yet
Projects
Quickwit 0.9
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingest V2 misses commit force
2 participants
@rdettai @fulmicoton