Fix krb5 transitive dependency cross build #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
approved these changes
Nov 21, 2024
rdettai
force-pushed
the
fix-nightly-krb5
branch
from
eee9a71 to
c1565fb
Compare
rdettai
force-pushed
the
fix-nightly-krb5
branch
from
c1565fb to
18880ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current nightly builds are failing on ARM because of the transitive dep krb5-sys (imported by rdkafka SASL)
The issue started after #5486 which upgraded the krb5-sys, in which MaterializeInc/rust-krb5-src#27 somehow broke the cross build instead of fixing it.
How was this PR tested?
Describe how you tested this PR.