Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures the affinity function is the same as in Quickwit 0.8 #5580

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

fulmicoton
Copy link
Contributor

Closes #5576

@fulmicoton fulmicoton force-pushed the issue/5576-fix-change-in-affinity-function branch 3 times, most recently from d916e2c to 0b8d821 Compare December 10, 2024 12:33
@trinity-1686a
Copy link
Contributor

quickwit/quickwit-search/src/cluster_client.rs and quickwit/quickwit-search/src/search_job_placer.rs were modified in #5564, i think a comprehensive fix should revert some of these change. That would likely mean changing quickwit/quickwit-common/src/rendezvous_hasher.rs::node_affinity() (and all its callers) to use an SocketAddr instead of a impl Hash

@fulmicoton fulmicoton force-pushed the issue/5576-fix-change-in-affinity-function branch from 0b8d821 to 7d614c8 Compare December 10, 2024 13:25
@fulmicoton fulmicoton force-pushed the issue/5576-fix-change-in-affinity-function branch from e38a7d9 to 0432c5e Compare December 10, 2024 16:08
@fulmicoton fulmicoton enabled auto-merge (squash) December 11, 2024 15:53
@fulmicoton fulmicoton merged commit ec95419 into main Dec 11, 2024
4 of 5 checks passed
@fulmicoton fulmicoton deleted the issue/5576-fix-change-in-affinity-function branch December 11, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needless change in affinity function
2 participants