Skip to content

Commit

Permalink
chore: deprecate python 3.8 (#391)
Browse files Browse the repository at this point in the history
  • Loading branch information
wallies authored Nov 24, 2024
1 parent fe13559 commit 5cb9657
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 14 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ jobs:
run: cargo fmt --check

Test:
continue-on-error: ${{ matrix.python-version == '3.13' }}
env:
UNSAFE_PYO3_SKIP_VERSION_CHECK: ${{ matrix.unsafe-pyo3-skip-version-check }}
strategy:
Expand All @@ -54,8 +53,11 @@ jobs:
include:
- os: ubuntu-latest
python-version: "3.13"
allow-prereleases: true
allow-prereleases: false
unsafe-pyo3-skip-version-check: 1
- os: ubuntu-latest
python-version: "3.12"
allow-prereleases: false
- os: ubuntu-latest
python-version: "3.11"
allow-prereleases: false
Expand All @@ -65,9 +67,6 @@ jobs:
- os: ubuntu-latest
python-version: 3.9
allow-prereleases: false
- os: ubuntu-latest
python-version: 3.8
allow-prereleases: false
runs-on: "${{ matrix.os }}"
steps:
- name: Harden Runner
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ jobs:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
with:
python-version: 3.8
python-version: 3.9
architecture: x64

- uses: PyO3/maturin-action@ea5bac0f1ccd0ab11c805e2b804bfcb65dac2eab
with:
manylinux: auto
target: ${{ matrix.platform }}
command: build
args: --release --sdist -o dist -i 3.8 3.9 3.10 3.11 3.12 3.13
args: --release --sdist -o dist -i 3.9 3.10 3.11 3.12 3.13

- name: Upload wheels
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # 4.4.3
Expand All @@ -74,7 +74,7 @@ jobs:
strategy:
matrix:
target: [x64]
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
steps:
- name: Harden Runner
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f
Expand Down Expand Up @@ -107,7 +107,7 @@ jobs:
attestations: write # persist the attestation
strategy:
matrix:
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
target: ['universal2', 'x86_64-apple-darwin']
steps:
- name: Harden Runner
Expand Down Expand Up @@ -162,10 +162,10 @@ jobs:
with:
toolchain: "stable"

- name: Set up Python 3.8
- name: Set up Python 3.9
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: 3.8
python-version: 3.9

- uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
with:
Expand Down
2 changes: 1 addition & 1 deletion ci/deploy_mac.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

maturin publish \
--interpreter python3.8 \
--interpreter python3.9 \
--username __token__ \
--password "$MATURIN_PASSWORD" \
--no-sdist
2 changes: 1 addition & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import nox


@nox.session(python=["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"])
@nox.session(python=["3.9", "3.10", "3.11", "3.12", "3.13"])
def test(session):
session.install("-rrequirements-dev.txt")
session.install("-e", ".", "--no-build-isolation")
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "maturin"

[project]
name = "tantivy"
requires-python = ">=3.8"
requires-python = ">=3.9"

[project.optional-dependencies]
dev = [
Expand Down

0 comments on commit 5cb9657

Please sign in to comment.