Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transport parameter for draft-12 #474

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Update transport parameter for draft-12 #474

merged 5 commits into from
Jan 22, 2025

Conversation

Yanmei-Liu
Copy link
Contributor

As we have add new frame type PATH_CIDS_BLOCKED frame, we'd need a new transport parameter type.
BTW, as the transport parameter type is hex value, I used 0x0c for draft-12.

@Yanmei-Liu Yanmei-Liu requested review from huitema and mirjak December 11, 2024 07:24
@mirjak
Copy link
Collaborator

mirjak commented Dec 11, 2024

yes, it's an hex value but I thought the intention was to map the last two values to the decimal revision number of the draft. At least that was my understanding of what we did so far, so let's not change this now.

@Yanmei-Liu
Copy link
Contributor Author

yes, it's an hex value but I thought the intention was to map the last two values to the decimal revision number of the draft. At least that was my understanding of what we did so far, so let's not change this now.

As an engineer, I thought it would be strange to mix hex and decimal values together, a little bit tricky.
But it's not a major issue and I updated the last two values with "0x12", please have a look again!

@huitema
Copy link
Contributor

huitema commented Dec 16, 2024

We have been using hex values for QUIC version numbers for some time. See https://github.com/quicwg/base-drafts/wiki/QUIC-Versions. The convention was to use version number '0xFF0000xx' for the draft N, were 'xx' was the hexadecimal notation for n. For example, the version for draft-34 was '0xFF000022'.

I think we could just keep the '0c' value for draft 12.

Copy link
Contributor Author

@Yanmei-Liu Yanmei-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @huitema 's comments, I keep the hex value version in this commit if we decide to keep it.

draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
draft-ietf-quic-multipath.md Outdated Show resolved Hide resolved
@mirjak
Copy link
Collaborator

mirjak commented Dec 16, 2024

Sure we can do one or the other but we have used the (decimal) draft version number so far, so why should we change it now?

@mirjak mirjak merged commit 1cd0896 into main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants