rename FOO.BAR packages to FOO/BAR #831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stylewarning
requested review from
appleby,
braised-babbage,
karlosz,
kartik-s,
notmgsk and
ecpeterson
|
tests won't pass (edit: here on github) because qvm won't be able to load |
stylewarning
force-pushed
the
packageslash
branch
from
6a5b0ca to
38b4e54
Compare
appleby
previously approved these changes
Jul 13, 2022
|
|
||
| (defpackage #:cl-quil | ||
| (:nicknames #:quil) |
| @@ -1353,7 +1336,7 @@ | |||
| ;;; access "internal" symbols. Having such symbols cataloged here is | |||
| ;;; preferable to simply accessing any symbol whatsoever via full | |||
| ;;; qualification, ala the use of package name "quil" with double | |||
There was a problem hiding this comment.
Suggested change
| ;;; qualification, ala the use of package name "quil" with double | |
| ;;; qualification, ala the use of package name "cl-quil" with double |
boom. gottem.
| @@ -2,7 +2,7 @@ | |||
| ;;;; | |||
| ;;;; Author: A.J. Nyquist | |||
|
|
|||
| (defpackage #:cl-quil.chip-library | |||
| (defpackage #:cl-quil/chip-library | |||
| (:use #:cl) | |||
| (:local-nicknames (:q :cl-quil) | |||
karlosz
previously approved these changes
Jul 14, 2022
stylewarning
dismissed stale reviews from notmgsk, karlosz, and appleby
via
3509dcd
stylewarning
force-pushed
the
packageslash
branch
from
38b4e54 to
3509dcd
Compare
stylewarning
force-pushed
the
packageslash
branch
from
3509dcd to
b4462b1
Compare
stylewarning
force-pushed
the
packageslash
branch
from
b4462b1 to
d8e5f1d
Compare
|
I'm not convinced this PR is a good idea anymore.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a heavy renaming of all of our
foo.barpackage names tofoo/bar.The reason is that in old CMUCL and in Allegro CL, the
foo.barnotation is for hierarchical packages, a non-standard Lisp feature that gives you nested namespaces. Moreover, the discrepancy between systems using/and packages using.had no good explanation.This also removes all
rename-packageand conditionals on package-local-nicknames. We just assume you have it now.This cleans up some existing nicknames due to issues/conflicts in the packages.lisp file
I'm a little worried I didn't replace everything in various scripts, dockerfiles, etc.
See also (required): quil-lang/qvm#294