Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename quil.foo to quil/foo #294

Closed
wants to merge 1 commit into from
Closed

rename quil.foo to quil/foo #294

wants to merge 1 commit into from

Conversation

stylewarning
Copy link
Member

@stylewarning stylewarning commented Jul 12, 2022

See quil-lang/quilc#831

also fixes #295

@stylewarning stylewarning force-pushed the slashpackage branch 6 times, most recently from 5860591 to 5bcd9a0 Compare July 12, 2022 19:55
@stylewarning stylewarning marked this pull request as ready for review July 12, 2022 19:57
@stylewarning
Copy link
Member Author

tests won't pass because of quilc

@stylewarning stylewarning force-pushed the slashpackage branch 2 times, most recently from 9bab7fa to 6eb60dd Compare July 12, 2022 20:07
@@ -37,8 +37,8 @@
:collect (string-downcase k) :collect v))

(defun plist->json (plist)
(with-output-to-string (*standard-output*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@@ -228,8 +228,8 @@ Invalid persistent QVM token. Expected a v4 UUID. Got \"5e2e05f0-f91c-5f02-96ef-
:qvm-token "5e2e05f0-f91c-4f02-96ef-361ffc55a0fa")
:status 500
:response-callback (response-error-checker "QVM RPC Error: Internal Server Error
Failed to find persistent QVM #1=5e2e05f0-f91c-4f02-96ef-361ffc55a0fa
Failed to find key #1# in SAFETY-HASH")))))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoulda used a regex
j/k

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in hindsight this check might have been a tad overly specific.

@stylewarning stylewarning deleted the slashpackage branch July 26, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YASON variable unbound
2 participants