-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename quil.foo to quil/foo #294
Conversation
5860591
to
5bcd9a0
Compare
tests won't pass because of quilc |
9bab7fa
to
6eb60dd
Compare
6eb60dd
to
f7a1eec
Compare
@@ -37,8 +37,8 @@ | |||
:collect (string-downcase k) :collect v)) | |||
|
|||
(defun plist->json (plist) | |||
(with-output-to-string (*standard-output*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬
@@ -228,8 +228,8 @@ Invalid persistent QVM token. Expected a v4 UUID. Got \"5e2e05f0-f91c-5f02-96ef- | |||
:qvm-token "5e2e05f0-f91c-4f02-96ef-361ffc55a0fa") | |||
:status 500 | |||
:response-callback (response-error-checker "QVM RPC Error: Internal Server Error | |||
Failed to find persistent QVM #1=5e2e05f0-f91c-4f02-96ef-361ffc55a0fa | |||
Failed to find key #1# in SAFETY-HASH"))))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shoulda used a regex
j/k
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in hindsight this check might have been a tad overly specific.
See quil-lang/quilc#831
also fixes #295