-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict check on browser side code #137
Conversation
🦋 Changeset detectedLatest commit: 5adb449 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@zubairaziz would love your review and expertise on how to skip expo app check, can revert if you see a problem. |
I don't see anything wrong with what you're doing here, but is there anywhere we can get the types for expo so that we can maybe have: declare global {
interface Window {
expo?: ExpoType
}
} instead of: declare global {
interface Window {
expo: any
}
} |
where can I get |
Yeah, I'm not sure. I just used |
I will check it again if we need it then, right now we are not even accessing actual value of the expo window object, just want find a way to skip it. |
Turns out expo has
window
but doesn't havewindow.addEventListener
.So when I import
@quiltt/core
in the react native sdk and use it in an expo app, it just blows up.I have a hard time to just use
@quiltt/core
directly in the expo example app, so hoping to add one more check, bump the version so I can use the next@quiltt/core
directly in the expo example app.In
node
In browser
In Expo