Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Connector onAuthenticate callback #150

Closed
wants to merge 2 commits into from
Closed

Expose Connector onAuthenticate callback #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bfb784
Expose onAuthenticate Connector callback
rubendinho Nov 8, 2023
8e9527b
Add changeset
rubendinho Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/eighty-poems-punch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@quiltt/react": patch
"@quiltt/core": patch
"@quiltt/react-native": patch
"@quiltt/react-test-nextjs": patch
---

Expose `onAuthenticate` callback on Quiltt Connector
6 changes: 6 additions & 0 deletions ECMAScript/core/src/api/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
interface CallbackManager {
onEvent(callback: ConnectorSDKOnEventCallback): void
onLoad(callback: ConnectorSDKOnLoadCallback): void
onAuthenticate(callback: ConnectorSDKOnAuthenticateCallback): void
onExit(callback: ConnectorSDKOnEventExitCallback): void
onExitSuccess(callback: ConnectorSDKOnExitSuccessCallback): void
onExitAbort(callback: ConnectorSDKOnExitAbortCallback): void
Expand All @@ -9,6 +10,7 @@ interface CallbackManager {
// Because it's well within React behavior to try to register a billion functions
offEvent(callback: ConnectorSDKOnEventCallback): void
offLoad(callback: ConnectorSDKOnLoadCallback): void
offAuthenticate(callback: ConnectorSDKOnAuthenticateCallback): void
offExit(callback: ConnectorSDKOnEventExitCallback): void
offExitSuccess(callback: ConnectorSDKOnExitSuccessCallback): void
offExitAbort(callback: ConnectorSDKOnExitAbortCallback): void
Expand Down Expand Up @@ -36,6 +38,7 @@ export interface ConnectorSDKConnector extends CallbackManager {
export type ConnectorSDKCallbacks = {
onEvent?: ConnectorSDKOnEventCallback
onLoad?: ConnectorSDKOnLoadCallback
onAuthenticate?: ConnectorSDKOnAuthenticateCallback
onExit?: ConnectorSDKOnEventExitCallback
onExitSuccess?: ConnectorSDKOnExitSuccessCallback
onExitAbort?: ConnectorSDKOnExitAbortCallback
Expand All @@ -48,6 +51,7 @@ export type ConnectorSDKOnEventCallback = (
) => void

export type ConnectorSDKOnLoadCallback = (metadata: ConnectorSDKCallbackMetadata) => void
export type ConnectorSDKOnAuthenticateCallback = (metadata: ConnectorSDKCallbackMetadata) => void

export type ConnectorSDKOnEventExitCallback = (
type: ConnectorSDKEventType,
Expand All @@ -60,6 +64,7 @@ export type ConnectorSDKOnExitErrorCallback = (metadata: ConnectorSDKCallbackMet

export enum ConnectorSDKEventType {
Load = 'loaded',
Authenticate = 'authenticated',
ExitSuccess = 'exited.successful',
ExitAbort = 'exited.aborted',
ExitError = 'exited.errored',
Expand All @@ -68,6 +73,7 @@ export enum ConnectorSDKEventType {
export type ConnectorSDKCallbackMetadata = {
connectorId: string
connectionId?: string
profileId?: string
}

export type ConnectorSDKConnectOptions = ConnectorSDKCallbacks
Expand Down
8 changes: 8 additions & 0 deletions ECMAScript/react/src/hooks/useQuilttConnector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ export const useQuilttConnector = (
return () => connector.offLoad(options.onLoad as any)
}, [connector, options?.onLoad])

// onAuthenticate
useEffect(() => {
if (!connector || !options?.onAuthenticate) return

connector.onAuthenticate(options.onAuthenticate)
return () => connector.offAuthenticate(options.onAuthenticate as any)
}, [connector, options?.onAuthenticate])

// onExit
useEffect(() => {
if (!connector || !options?.onExit) return
Expand Down