Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-native] Refactor "QuilttConnector" for better visibility #266

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

zubairaziz
Copy link
Collaborator

@zubairaziz zubairaziz commented Jun 4, 2024

Changes

  1. CI/CD Workflows:
  • .github/workflows/ci.yml:
    • Updated pnpm/action-setup to version v4.
  • .github/workflows/tests-unit.yml:
    • Updated pnpm/action-setup to version v4.
  1. Node Version:
  • .nvmrc:
    • Changed Node version from v20.12.2 to v20.14.0.
  1. Dependencies and Package Management:
  • package.json:
  • packages/react-native/package.json:
    • Added "base-64": "1.0.0", "react-native-url-polyfill": "2.0.0", and "react-native
  • webview": "13.10.2" dependencies.
    • Updated "@types/base-64" from 0.1.0 to 1.0.2.
  1. Code Refactor:
  • packages/react-native/declarations.d.ts:
    • Deleted this file as it is no longer needed.
  • packages/react-native/src/components/QuilttConnector.tsx:
    • Moved and refactored utility functions checkConnectorUrl and handleOAuthUrl directly into the component file.
    • Enhanced error handling and preflight check mechanisms.
    • Removed the unused URL allow list logic.
  • packages/react-native/src/utils/connector:
    • Deleted the now-inlined utility functions and their respective files.
  • packages/react-native/src/utils/index.ts:
    • Adjusted exports to remove the connector utilities.
  1. Testing:
  • packages/react-native/tests/components/QuilttConnector.test.tsx:
    • Added comprehensive tests for the QuilttConnector component.
  • Improved mocks and added new test cases for preflight checks and OAuth handling.

@zubairaziz zubairaziz self-assigned this Jun 4, 2024
Copy link

changeset-bot bot commented Jun 4, 2024

⚠️ No Changeset found

Latest commit: a6d6640

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zubairaziz zubairaziz marked this pull request as ready for review June 5, 2024 00:12
@zubairaziz zubairaziz requested a review from rubendinho June 5, 2024 00:13
@zubairaziz zubairaziz merged commit 486ab04 into main Jun 18, 2024
13 checks passed
@zubairaziz zubairaziz deleted the react-native_refactor-quiltt-connector branch June 18, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants