Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types #296

Merged
merged 2 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/smart-lamps-relate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@quiltt/react-native": patch
"@quiltt/react": patch
"@quiltt/core": patch
---

Fix typings
15 changes: 10 additions & 5 deletions packages/core/src/api/browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,13 +115,11 @@ export type ConnectorSDKCallbackMetadata = {

/**
Options for the standard Connect flow
@param institution The Institution search term or ID to preload
@param institution The Institution ID or search term to connect
*/
export type ConnectorSDKConnectOptions = ConnectorSDKCallbacks & {
/** The Institution search term or ID to preload */
/** The Institution ID or search term to connect */
institution?: string
/** The ID of the Connection to reconnect */
connectionId?: string
}

/**
Expand All @@ -134,4 +132,11 @@ export type ConnectorSDKReconnectOptions = ConnectorSDKCallbacks & {
}

/** Options to initialize Connector */
export type ConnectorSDKConnectorOptions = ConnectorSDKConnectOptions | ConnectorSDKConnectOptions
// @todo: refactor into a union type - it's either or.
export type ConnectorSDKConnectorOptions = ConnectorSDKCallbacks & {
/** The Institution ID or search term to connect */
institution?: string

/** The ID of the Connection to reconnect */
connectionId?: string
}
11 changes: 6 additions & 5 deletions packages/react/src/hooks/useQuilttConnector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

import { useCallback, useEffect, useState } from 'react'

import {
type ConnectorSDK,
type ConnectorSDKConnector,
type ConnectorSDKConnectorOptions,
cdnBase,
import { cdnBase } from '@quiltt/core'

import type {
ConnectorSDK,
ConnectorSDKConnector,
ConnectorSDKConnectorOptions,
} from '@quiltt/core'

import { version } from '../version'
Expand Down
Loading