Minor cleanup #343
Merged
Minor cleanup #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variables are not used any longer. They generally fall in 4 buckets: - used in restart/pause, which was removed in 834bf10 - used when merge and upload were two commands, before 8244318 - used in old insights upload, removed in 98c5476 - dating back to when qpc and quipucords were single codebase, before d24ed3d
infinitewarp
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to work on DISCOVERY-458 , but then I discovered that there's hardly anything to do. But since I was there already, I decided to clean up things a little.
f13d2ef removes
filehandle.close()call after context manager. File is closed by context manager on exit.a94d8f2 removes a bunch of variables from
messages.py. These variables are no longer used - they generally belong to features that have since been removed (old insights upload, restart/pause, separate merge and upload), but some of them date back to when CLI and backend shared single repo - they were never really used in CLI.