feat: better output and exit code from incomplete commands #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way argparse validates incomplete subparser (subcommand) inputs. By setting
required=true
, argparse correctly halts processing, displays a useful error message, and returns a non-zero exit code.Old handling of incomplete commands:
Note that the old output simply dumps the top-level help message which does not actually help with the provided
server
subcommand, and it exits with0
which wrongly indicates success.New handling of incomplete commands: