Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update build dependencies, fix minor lint and test issues, update qpc version to 1.8.2 #347

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

infinitewarp
Copy link
Member

@infinitewarp infinitewarp commented Jul 15, 2024

  • Better output and exit code from incomplete commands.
  • Minor performance updates and cleanup.

Relates to JIRA: DISCOVERY-719

closes #345

@infinitewarp infinitewarp requested a review from a team July 15, 2024 16:29
PLW0133 [*] Missing `raise` statement on exception
@infinitewarp infinitewarp changed the title build: update qpc version to 1.8.2 build: fix minor lint and test issues, update qpc version to 1.8.2 Jul 15, 2024
@infinitewarp infinitewarp changed the title build: fix minor lint and test issues, update qpc version to 1.8.2 build: update build dependencies, fix minor lint and test issues, update qpc version to 1.8.2 Jul 15, 2024
@infinitewarp infinitewarp requested review from bruno-fs and a team July 15, 2024 18:15
PLR1704 Redefining argument with the local name `json_file`
Copy link
Contributor

@bruno-fs bruno-fs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

qpc/tests/report/test_report_deployments.py Outdated Show resolved Hide resolved
- Better output and exit code from incomplete commands.
- Minor performance updates and cleanup.

Relates to JIRA: DISCOVERY-719
@infinitewarp infinitewarp merged commit bdcf25f into main Jul 15, 2024
19 checks passed
@infinitewarp infinitewarp deleted the updates branch July 15, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants