Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 of 3, remaining alpha commits #391

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Conversation

cdcabrera
Copy link
Contributor

@cdcabrera cdcabrera commented Jul 18, 2024

What's included

  • build(Containerfile,Makefile): container build support
  • test: ds-680 add unit tests to hooks/useAlerts
  • test: ds-680 unit tests to hooks/useCredentialApi
  • refactor(useSearchParam): ds-680 remove unused hook
  • ci: ds-647 reorder lint, build, test actions
  • ci: ds-647 favor jest coverage report, remove codecov

Notes

  • Minor adjustments based on updated linting rules has been applied to the the test: ds-680* commits
  • Removes the non-functioning codecov implementation. codecov changed their terms of service, this project may not fall under the "free" tier, needs review.
    • There is an alternative approach we can take if we want coverage reports that involves posting the coverage report to a github pages site we control and then using a custom README badge that links over to the hosted pages... this would be free and provide easy access to coverage reports. the only thing it wouldn't cover is the github PR/MR comment that codecov applies (when it works)

How to test

Lint test check

  1. update the NPM packages with $ npm install
  2. $ npm run test:ci-lint
  3. confirm the lint checks come back clean

Build test check

  1. update the NPM packages with $ npm install
  2. $ npm run test:ci-build
  3. confirm the build checks come back clean

Unit test check

  1. update the NPM packages with $ npm install
  2. $ npm run test:ci-coverage
  3. confirm the unit test checks fail because of missing coverage minimums

Local randomized data run check

  1. update the NPM packages with $ npm install
  2. $ npm run start
  3. confirm the ui displays as intended

Local staging run check

  1. update the NPM packages with $ npm install
  2. $ npm run start:stage
  3. confirm the ui displays as intended

Example

...

Updates issue/story

blocked by #390 #389

@cdcabrera cdcabrera force-pushed the 202407-leftover branch 2 times, most recently from 44b2944 to cff5691 Compare July 23, 2024 19:33
cdcabrera and others added 6 commits July 23, 2024 16:18
* ds-521, 536 container build support
* ds-650 Adding a top level Makefile (quipucords#334)
* ds-631 clean up Yarn towards NPM (quipucords#342)
* ds-358 add support for enabling V1 vs V2 UI (quipucords#344)

Relates to JIRA: DISCOVERY-521 DISCOVERY-536 DISCOVERY-650 DISCOVERY-631 DISCOVERY-358

Co-Authored-By: Bruno Ciconelle <[email protected]>
Co-Authored-By: Alberto Bellotti <[email protected]>
Co-Authored-By: Nicole Aragao <[email protected]>
@cdcabrera cdcabrera requested a review from nicolearagao July 23, 2024 20:34
@cdcabrera cdcabrera marked this pull request as ready for review July 23, 2024 20:34
@cdcabrera cdcabrera merged commit e9667f2 into quipucords:main Jul 25, 2024
2 of 4 checks passed
cdcabrera added a commit that referenced this pull request Jul 25, 2024
* ds-521, 536 container build support
* ds-650 Adding a top level Makefile (#334)
* ds-631 clean up Yarn towards NPM (#342)
* ds-358 add support for enabling V1 vs V2 UI (#344)

Relates to JIRA: DISCOVERY-521 DISCOVERY-536 DISCOVERY-650 DISCOVERY-631 DISCOVERY-358

Co-Authored-By: Bruno Ciconelle <[email protected]>
Co-Authored-By: Alberto Bellotti <[email protected]>
Co-Authored-By: Nicole Aragao <[email protected]>
cdcabrera added a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants