Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a utility script to make development easier #512

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

bruno-fs
Copy link
Contributor

@bruno-fs bruno-fs commented Nov 6, 2024

npm run start:using-server will serve the development UI properly wired to a running instance of quipucords server. Default configuration points to quipucords-installer defaults, and can be customized with QUIPUCORDS_SERVER_* variables.

@bruno-fs bruno-fs requested a review from a team November 7, 2024 12:33
Copy link
Contributor

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of choices, and a non-blocking recommendation

package.json Show resolved Hide resolved
@cdcabrera
Copy link
Contributor

Another recommendation is to update the commit from chore to build since you're actively affecting the scripts that let us run and build everything

npm run start:using-server will serve the development UI properly
wired to a running instance of quipucords server. Default configuration
points to quipucords-installer defaults, and can be customized
with QUIPUCORDS_SERVER_* variables.
Copy link
Member

@nicolearagao nicolearagao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@infinitewarp infinitewarp merged commit 72347e7 into main Jan 14, 2025
9 of 10 checks passed
@infinitewarp infinitewarp deleted the start-using-server branch January 14, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants