Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): lock reset #520

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

cdcabrera
Copy link
Contributor

@cdcabrera cdcabrera commented Nov 19, 2024

What's included

  • build(deps): lock reset

Notes

  • helps update patch versions of packages
    • the process helps with the "audit" checks and passing. for the future this process can be achieved by
      1. simply deleting the lockfile
      2. using the correct version of NodeJS, currently 20 (18 should be considered deprecated)
      3. then running $ npm install again
      4. confirm the lockfile actually patched questionable prod deps by running $ npm audit.
        • if the audit check is still firing then there's no need to check/commit the lockfile back in, skip the last step
        • look for updated major and minor package updates with a fallback towards replacing the package
      5. finally, check/commit the updated lockfile back in

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm run start:stage
  3. confirm the display runs as intended

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

ongoing

@cdcabrera cdcabrera merged commit 085d09a into quipucords:main Nov 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants