-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds qemu-img commit patch for Cinder with v3 Kernels
- Loading branch information
1 parent
d0bd3e3
commit 4c6b0b4
Showing
3 changed files
with
28 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
|
||
## qemu-img_commit_patch for old v3 kernels | ||
|
||
Backports a very simple patch for Cinder setups that use qemu-img version 2.10+ with v3.10 Kernels. In case a setup hits issues with qemu-img crashing in a qemu-img commit call during snapshot deletion this patch provides a simple fix. | ||
The patch has been added upstream with [change #6200926](https://review.openstack.org/#/c/620926/) and will be ported back to the previous three releases. Older releases are provided with this patch via this repository. | ||
|
||
|
||
### Installation | ||
|
||
This patch can be applied by navigating to the Cinder project source root directory and running: | ||
|
||
patch -p1 < /path/to/patchfile |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/cinder/volume/drivers/remotefs.py b/cinder/volume/drivers/remotefs.py | ||
index 6f07cb90c..54f15f2ca 100644 | ||
--- a/cinder/volume/drivers/remotefs.py | ||
+++ b/cinder/volume/drivers/remotefs.py | ||
@@ -744,7 +744,7 @@ class RemoteFSSnapDriverBase(RemoteFSDriver): | ||
# NFS snapshots | ||
# It needs to run as root for volumes attached to instances, but | ||
# does not when in secure mode. | ||
- self._execute('qemu-img', 'commit', path, | ||
+ self._execute('qemu-img', 'commit', '-d', path, | ||
run_as_root=self._execute_as_root) | ||
self._delete(path) | ||
|