HtmlFilter: fix an off-by-one error in minimized attrs processing

...leading to HTML corruption which the filter itself occasionally trips over.
quotient-im · Nov 20, 2024 · 12a0ec5 · 12a0ec5
1 parent 54fc44d
commit 12a0ec5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/client/htmlfilter.cpp b/client/htmlfilter.cpp
@@ -268,10 +268,10 @@ static const auto mxBgColorAttr = u"data-mx-bg-color";
                && m.capturedEnd(1) < gtPos) {
             pos = m.capturedEnd();
             if (m.captured(2).isEmpty()) {
-                static const auto attrValue = QString("=''");
+                static const auto attrValue = u"=''"_s;
                 html.insert(m.capturedEnd(1), attrValue);
-                gtPos += attrValue.size() - 1;
-                pos += attrValue.size() - 1;
+                gtPos += attrValue.size();
+                pos += attrValue.size();
             }
         }
         // Make sure empty elements are properly closed