More tweaks and cleanup #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a reaction is to an event that has not been loaded in the timeline there's no point to emit updatedEvent() as there's nothing to update.
This is a limited substitute for std::ranges::to() that is still not supported by Xcode. With plenty of other range adaptors not in Apple libc++ either, this can only be used sparingly but it's better this way than leaving a TODO in every place std::ranges::to() could have been used.
- FINISH_TEST_IF and FAIL_TEST_IF to collapse all those if/returns when you need to stop the test on condition but continue if it doesn't hold - finishTest() now uses std::source_location instead of C-era macros
The test was occasionally hitting the same target message as the redaction test, with the reaction test waiting forever to see the reaction on the message that just got redacted (with reactions being erased from it as a result).
|
TobiasFella
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly, sporadic
sendReactiontest failures fixed.