Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes - 0.10 #858

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Minor fixes - 0.10 #858

merged 2 commits into from
Jan 24, 2025

Conversation

KitsuneRal
Copy link
Member

This is the same as #857 but for dev.

@KitsuneRal
Connection::logout(): report when the promise is started
4a0edac 
(cherry picked from commit 84cfb9d)
@KitsuneRal
makeMediaUrl(): overwrite existing query items
0fca50c 
...instead of just appending key-value pairs.

(cherry picked from commit e7fe0b9)
@KitsuneRal KitsuneRal added bug/fix The library doesn't work as expected enhancement A feature or change request for the library labels Jan 24, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
33.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@KitsuneRal KitsuneRal merged commit 93a694f into dev Jan 24, 2025
11 checks passed
@KitsuneRal KitsuneRal deleted the kitsune/minor-fixes-0.10 branch January 24, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug/fix The library doesn't work as expected enhancement A feature or change request for the library
Projects
libQuotient 1
Status: 0.10 - Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KitsuneRal