Join rule event #862
Join rule event #862
Conversation
|
| QString roomId; | ||
| QString type; | ||
| }; | ||
| Q_NAMESPACE_EXPORT(QUOTIENT_API) |
There was a problem hiding this comment.
That doesn't quite work, unfortunately, because another header file might also need it and then we will end up with ODR violation at linking. For that reason, all namespace-level enumerations that need Q_ENUM are defined in quotient_common.h; it doesn't have Q_NAMESPACE_EXPORT for EventContent but I would argue that enum JoinRule is no different from, say, enum Membership and belongs to the main Quotient namespace.
| }; | ||
|
|
||
| //! Enum representing the available room join rules | ||
| enum JoinRule { |
There was a problem hiding this comment.
Always make sure your enums specify the underlying integer type. The standard leaves it for implementations to decide, so MSVC uses int if the type is omitted while GCC and both flavours of Clang use unsigned int - this is why the CI is failing on Windows now. I added the same integer type enum Membership uses but if you prefer uint8_t I won't mind :)
| enum JoinRule { | |
| enum JoinRule : uint16_t { |
Upstream join rule event from neochat