Merge pull request #43 from qupaya/at/feature/dialog-overlay-handling

fix: stop propagation on dialog escape
qupaya · Aug 12, 2024 · ca4c7b6 · ca4c7b6
2 parents 199074f + 5490883
commit ca4c7b6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/libs/sketch/src/lib/components/dialog/dialog.component.html b/libs/sketch/src/lib/components/dialog/dialog.component.html
@@ -3,7 +3,7 @@
   #dialogElement
   skClickBackdrop
   (clickedBackdrop)="close.emit()"
-  (keydown.escape)="close.emit()"
+  (keydown.escape)="handleEscape($event)"
   [class.display-flex]="open()"
 >
   <div

diff --git a/libs/sketch/src/lib/components/dialog/dialog.component.ts b/libs/sketch/src/lib/components/dialog/dialog.component.ts
@@ -67,4 +67,11 @@ export class DialogComponent {
     },
     { allowSignalWrites: true }
   );
+
+  handleEscape(event: Event): void {
+    this.close.emit();
+
+    event.preventDefault();
+    event.stopImmediatePropagation();
+  }
 }