Feature/select component #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickjahr
force-pushed
the
feature/select-component
branch
9 times, most recently
from
f57be20 to
a006cc4
Compare
BaggersIO
approved these changes
Apr 19, 2024
Comment on lines
+1
to
+9
| <sk-select [(ngModel)]="selectedValue"> | ||
| <span skSelectPlaceholder>Select option</span> | ||
| <span skSelectLabel>{{ selectedValue?.label }}</span> | ||
| @for (option of options; track option.value) { | ||
| <sk-select-option [value]="option"> | ||
| {{ option.label }} | ||
| </sk-select-option> | ||
| } | ||
| </sk-select> |
| private readonly window = inject(DOCUMENT)?.defaultView; | ||
|
|
||
| private readonly windowResize = this.window | ||
| ? toSignal(fromEvent(this.window, 'resize')) |
There was a problem hiding this comment.
Wie wärs mit throttle / debounce?
| styleUrl: './select.component.css', | ||
| encapsulation: ViewEncapsulation.ShadowDom, | ||
| }) | ||
| export class SelectComponent<T> implements ControlValueAccessor { |
patrickjahr
force-pushed
the
feature/select-component
branch
from
a006cc4 to
e8c0e51
Compare
added 11 commits
April 30, 2024 07:33
patrickjahr
force-pushed
the
feature/select-component
branch
from
e8c0e51 to
af92c80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.