Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is/feature/dialog #28

Merged
merged 50 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
c3aa5b3
feat: add dialog component
Apr 16, 2024
e9caced
refactor: change open to model
Apr 16, 2024
5fc1986
style: position dialog in center
Apr 17, 2024
412b273
refactor: change/simplify dialog implementation
Apr 17, 2024
b73ae4a
refactor: comment currently unused classes
Apr 17, 2024
d39e637
feat: add svg icon to close button and make it more generic
Apr 17, 2024
f4f17a7
feat: make styles for close button adjustable
Apr 17, 2024
3b22f65
feat: make backdrop style adjustable
Apr 17, 2024
95d5269
refactor: cleanup and renaming
Apr 17, 2024
dbe7b7e
chore: add doku WIP
Apr 17, 2024
b9e857a
feat: add blur styling option to backdrop
Apr 18, 2024
9704b06
chore: update documentation
Apr 18, 2024
d2c4356
refactor: simplify backdrop styling
Apr 22, 2024
25561bb
style: align close button and make width adjustable
Apr 22, 2024
edac274
style: make close button position adjustable
Apr 22, 2024
dd5fb82
chore: add documentation for content styling
Apr 22, 2024
7f12933
chore: add overview over all properties to documentation
Apr 23, 2024
251b463
feat: make the position of the inner close button adjustable
Apr 23, 2024
f669e9b
fix: add class to close button to avoid unwanted styling
Apr 23, 2024
74bc640
refactor: remove unneccassary dialogId input and selector
Apr 23, 2024
c6bf213
chore: update documentation
Apr 23, 2024
76901ba
feat: add examples in different variants
Apr 23, 2024
15547b9
feat: make height adjustable
Apr 24, 2024
62fed4e
feat: add fullscreen input
Apr 24, 2024
441ea1d
feat: add contentShadow input
Apr 24, 2024
8fb5cb8
refactor: change some default values of the dialog
Apr 24, 2024
c548094
chore: update documentation according to new implementations
Apr 24, 2024
a444fa0
refactor: change background-color to background for backdrop
Apr 25, 2024
8aa906b
chore: adjust documentation
Apr 25, 2024
f9864e6
chore: rename close output
Apr 25, 2024
b4736c4
refactor: adjust margin and height when no button or inner button
Apr 25, 2024
7d89912
refactor: adjust naming of classes and variables
Apr 25, 2024
4c568d6
refactor: adjust dialog custom properties
Apr 25, 2024
8e5e806
feat: add examples
Apr 25, 2024
ca929d0
feat: add option to add border
Apr 25, 2024
e159ccd
feat: add option to move outer close button independently of margin
Apr 29, 2024
1619654
fix: add margin if no close button but content shadow
Apr 29, 2024
1c3d46c
fix: add and adjust max-height for content container
Apr 29, 2024
d19b099
feat: add option to position close button on left side
Apr 29, 2024
9aa1698
refactor: remove closeButtonProperties and add option to add own clos…
Apr 29, 2024
9b24e68
refactor: add correct route for sample
Apr 30, 2024
78cafe2
feat: add storybook for dialog
May 2, 2024
82814cb
fix: adjust max-height of no margin container
May 2, 2024
d4d8b5b
fix: adjust display of wrapper to avoid interferences of innerCloseBu…
May 3, 2024
e675b2a
feat: enhance dialog documentation
May 3, 2024
c5c94da
chore: update documentation
May 3, 2024
a34d522
refactor: refactor code
May 3, 2024
e184155
refactor: remove todo comment
May 8, 2024
41d2343
refactor: add class to dialog for same css specificity
May 8, 2024
f7a25b4
refactor: remove unit test
May 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/demo-app/src/app/app.routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,12 @@ export const appRoutes: Route[] = [
},
],
},
{
path: 'dialog-sample',
loadComponent: () =>
import('./pages/dialog-sample/dialog-sample.component').then(
(m) => m.DialogSampleComponent
),
},
// TODO: Add routes for the other samples
];
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
button {
cursor: pointer;
}

.layout {
display: flex;
flex-direction: column;
gap: 20px;
}

.normal-close-button {
border: none;
padding: 10px;
width: 30px;
height: 30px;
display: flex;
align-items: center;
justify-content: center;
background-color: transparent;
}

.custom-close-button-style {
border-radius: 100px;
background-color: aquamarine;
border: none;
padding: 10px;
width: 30px;
height: 30px;
display: flex;
align-items: center;
justify-content: center;
}

/* default styles to see results better */
div:nth-child(n + 3) sk-dialog {
--sk-dialog-margin: 50px;
--sk-dialog-background: lightblue;
}

/* fully styled Dialog */
div:nth-child(2) sk-dialog {
--sk-dialog-width: 70%;
--sk-dialog-height: 50%;
--sk-dialog-margin: 50px;
--sk-dialog-container-margin: 40px;
--sk-dialog-container-padding: 40px;
--sk-dialog-outer-close-button-space: 10px;
--sk-dialog-inner-close-button-space: 15px;
--sk-dialog-border-radius: 20px;
--sk-dialog-border: 5px solid cornflowerblue;
--sk-dialog-background: lightblue;
--sk-dialog-content-shadow: rgb(0 0 0 / 20%) 0 10px 20px;
--sk-dialog-overflow: scroll;
--sk-dialog-backdrop: rgb(92 107 192 / 50%);
--sk-dialog-backdrop-blur: 2px;
}

/* Dialog with custom shadow */
div:nth-child(8) sk-dialog {
--sk-dialog-content-shadow: rgb(255 255 255 / 40%) 0 10px 20px;
--sk-dialog-container-margin: 30px;
}

/* Dialog with overflow */
div:nth-child(10) sk-dialog {
--sk-dialog-height: 50%;
}

/* Dialog with fancy colors */
div:nth-child(11) sk-dialog {
--sk-dialog-background: radial-gradient(
circle,
rgb(238 174 202 / 100%) 0%,
rgb(148 187 233 / 100%) 100%
);
--sk-dialog-backdrop: linear-gradient(
217deg,
rgb(255 0 0 / 80%),
rgb(255 0 0 / 0%) 70%
),
linear-gradient(127deg, rgb(0 255 0 / 80%), rgb(0 255 0 / 0%) 70%),
linear-gradient(336deg, rgb(0 0 255 / 80%), rgb(0 0 255 / 0%) 70%);
--sk-dialog-backdrop-blur: 3px;
}
Loading
Loading