Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): add overview and a little bit of styling #3

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

patrickjahr
Copy link
Collaborator

  • Changes
    -- add root page
    -- add demo cards to navigate to the component examples
    -- add little bit of styling

  • Open Todo
    -- Create pages for the sample dashboard cards

@patrickjahr patrickjahr requested a review from BaggersIO April 5, 2024 12:44
@patrickjahr patrickjahr force-pushed the feature/overview branch 3 times, most recently from e48ae55 to 7e1e2b6 Compare April 8, 2024 06:15
Copy link
Contributor

@BaggersIO BaggersIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke!

justify-content: flex-end;
gap: 1rem;

a {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wir versuchen, wenn möglich, CSS Klassen zu verwenden, um die Style Spezifität gleich zu halten. Was hältst Du davon? Wollen wir das in dem Projekt auch machen?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wir können gerne klassen verwenden. Würde diese dann aber mit dem prefix sk kennzeichnen. Das es klar ist, dass die Klassen aus unserer Lib kommen.

@patrickjahr patrickjahr merged commit 2aa6710 into main Apr 8, 2024
1 check passed
@patrickjahr patrickjahr deleted the feature/overview branch April 8, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants