setup-prettier-linting-husky #2183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AhmedCodeGuy
changed the title
osamasayed
approved these changes
Jul 2, 2024
osamasayed
added a commit
that referenced
this pull request
Jul 7, 2024
* fix missing ayahs in indopak translation mode * fetch data on the client * rename and move hook * fix loading bug * DRY code * pass correct data * fix data shape * add prettier, eslint, and lintstaged rules * hello world console log * set lint staged to default linting without fix * update husky and add lint fix flag * update package and add necessary setup * reset test component * fix linting errors and warnings * remove unused props * remove unused props * reset the line component --------- Co-authored-by: Osama Sayed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NO JIRA TICKET
Fixes the setup of husky hook pre-commit with lint-staged, added an eslint rule, and fixed the warnings and erorrs blocking the pre-commit.
Type of change
Test plan
Now it runs the pre-commit and blocks the commit if any warning or error generated from running eslint.
Checklist