Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QF-613-word-by-word-in-settings-dynamic-list #2185

Merged
merged 6 commits into from
Jul 7, 2024

Conversation

AhmedCodeGuy
Copy link
Collaborator

Summary

Fixes #613

Changes the word by word settings translations from static list to dynamic list fetched from the API.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test plan

The list is fetched dynamically and the UI matches the data fetched from the API, after filtering dublicate translations for the same language.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@AhmedCodeGuy AhmedCodeGuy self-assigned this Jul 3, 2024
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 11:39am

src/components/Navbar/SettingsDrawer/WordByWordSection.tsx Outdated Show resolved Hide resolved
src/utils/array.ts Outdated Show resolved Hide resolved
src/components/Navbar/SettingsDrawer/WordByWordSection.tsx Outdated Show resolved Hide resolved
src/utils/array.ts Outdated Show resolved Hide resolved
@osamasayed osamasayed merged commit eed82f7 into master Jul 7, 2024
7 checks passed
@osamasayed osamasayed deleted the QF-613-word-by-word-in-settings-dynamic-list branch July 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants