-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QF-613-word-by-word-in-settings-dynamic-list #2185
Merged
osamasayed
merged 6 commits into
master
from
QF-613-word-by-word-in-settings-dynamic-list
Jul 7, 2024
Merged
QF-613-word-by-word-in-settings-dynamic-list #2185
osamasayed
merged 6 commits into
master
from
QF-613-word-by-word-in-settings-dynamic-list
Jul 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
osamasayed
requested changes
Jul 3, 2024
osamasayed
requested changes
Jul 3, 2024
osamasayed
reviewed
Jul 3, 2024
osamasayed
requested changes
Jul 4, 2024
osamasayed
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #613
Changes the word by word settings translations from static list to dynamic list fetched from the API.
Type of change
Test plan
The list is fetched dynamically and the UI matches the data fetched from the API, after filtering dublicate translations for the same language.
Checklist