Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QF-1165]: resolves the build and redirect issue #2233

Merged
merged 3 commits into from
Nov 10, 2024
Merged

[QF-1165]: resolves the build and redirect issue #2233

merged 3 commits into from
Nov 10, 2024

Conversation

mohsinayoob
Copy link
Collaborator

Summary

Fixes #QF-1165 and resolve other build and redirect issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test plan

This should state how this PR have been tested.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots or videos

Before After
IMAGE HERE IMAGE HERE

@vercel Vercel
Copy link

vercel bot commented Nov 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 2:34pm

@osamasayed osamasayed merged commit 6debea4 into testing Nov 10, 2024
5 checks passed
@osamasayed osamasayed deleted the qf-1165build-and-redirect-issue branch November 10, 2024 14:40
osamasayed added a commit that referenced this pull request Nov 18, 2024
@mohsinayoob @osamasayed
[QF-1165]: resolves the build and redirect issue (#2233)
71412d4 
* fix: resolves the build and redirect issue

* Fix cyclic dependency issue

* fix TS issue

---------

Co-authored-by: Osama Sayed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohsinayoob @osamasayed