Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Fix audio issues #1098

Open
wants to merge 340 commits into
base: master
Choose a base branch
from
Open

Conversation

imadmk
Copy link
Contributor

@imadmk imadmk commented Jul 31, 2019

Fix audio issues #1080 and more

  • Fix audio error on change chapter
  • Fix audio cannot be paused by verse control
  • Fix double click on Word

Checklist

  • Manually tested
  • Prettier & ESLint were run

mmahalwy and others added 30 commits October 11, 2017 16:58
* Adding events config

* events for components

* reorganize
Persian language for quran.com-frontend locale fully translated from English file within the project.
Added 'fa' for Persian language in config.
Just added fa: 'فارسی' to config
Persian language for quran.com-frontend
…quran#880)

* removed more CSS

* Not needed files

* Remove more unneeded css!
* eslint pass

* remove files not used

* fix yarn

* origin master yarn
* Adding PR Template

* Change to checklist

* eslint

* move contributing too
* eslint fix

* Close to working, next add loading states for surah

* working on surah!
Skillz4Killz and others added 26 commits January 28, 2019 10:45
* fix facebook and twitter icons to be inline

* a small bit of padding to make it look better
some fix on persian translation
Ensure suggestions is an array and close autocomplete on search
fixed ayah number and sakoon glyphs
أشكركم على الجهد المبارك واسأل الله أن يجعله في موازين حسناتكم.
فيما يلي وصف للتعديل الذي قمت به:
1. تصحيح أخطاء إملائية ونحوية
2. تصحيح الترجمة ونقلها من الحرفية إلى المعنوية لتناسب السياق

والذي دفعني لهذا بدايةً هو رؤيتي لكلمة "لعب" في محل تشغيل المقطع الصوتي للآية.
بارك الله فيكم
- Fix audio error on change chapter
- Fix audio cannot be paused by verse control
- Fix double click on word
@imadmk
Copy link
Contributor Author

imadmk commented Jul 31, 2019

Sorry, forgot to restore tooltip on Word.tsx

restored and update react-tippy

FYI: actually, react-tippy already abandoned, there is actually an official repo of tippy, but i think the usage of the tooltip is only on words so no need to change repo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.