Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Bug fixes #33

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[WIP] Bug fixes #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
105d187
missing changes for sentry
mahmoudfelfel Nov 3, 2018
32ff9dd
FIX 1: show descriptions for reciters whenever available
mahmoudfelfel Nov 3, 2018
a39fa11
FIX 2: show only chapters with valid audio files, FIX 3: highlight su…
mahmoudfelfel Nov 3, 2018
d76fe8d
remove sentry token [pushed by mistake]
mahmoudfelfel Nov 3, 2018
c9fb176
Fix for the remote-next event
mahmoudfelfel Nov 4, 2018
d8b54a8
Merge branch 'bug-fixes' of github.com:mahmoudfelfel/quranicaudio-app…
mahmoudfelfel Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions android/sentry.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
defaults.url=https://sentry.io/
defaults.org=qurancom
defaults.project=quranicaudio
auth.token=
cli.executable=node_modules/@sentry/cli/bin/sentry-cli
10 changes: 10 additions & 0 deletions ios/quranicaudio.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
52A2FFFCB1414E888AB98D1B /* FontAwesome5_Solid.ttf in Resources */ = {isa = PBXBuildFile; fileRef = FA5C757A0DD14C5AA0DD7365 /* FontAwesome5_Solid.ttf */; };
5E9157361DD0AC6A00FF2AA8 /* libRCTAnimation.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 5E9157331DD0AC6500FF2AA8 /* libRCTAnimation.a */; };
6155AC9A2BA14EC094204FC9 /* MaterialCommunityIcons.ttf in Resources */ = {isa = PBXBuildFile; fileRef = 1624FA57629F4FAAA34B434D /* MaterialCommunityIcons.ttf */; };
635C9ACE88614F23A21A1EB8 /* libz.tbd in Frameworks */ = {isa = PBXBuildFile; fileRef = 4BD539E800C14A33A1A15AA1 /* libz.tbd */; };
737E269243C74478BA7F871F /* FontAwesome.ttf in Resources */ = {isa = PBXBuildFile; fileRef = 0643DB93CD9F4A6BA56CEF67 /* FontAwesome.ttf */; };
832341BD1AAA6AB300B99B32 /* libRCTText.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 832341B51AAA6A8300B99B32 /* libRCTText.a */; };
87EBAEED5E2948C0A31B5831 /* Feather.ttf in Resources */ = {isa = PBXBuildFile; fileRef = 9201E557913A44C0B1A66C9B /* Feather.ttf */; };
Expand Down Expand Up @@ -483,6 +484,8 @@
F1C5DC63952B4D919BA44527 /* libRNVectorIcons.a in Frameworks */,
2C6FB26FA0714BF683DC4EFD /* libRCTVideo.a in Frameworks */,
8F63D808B7C54C3D97E1FD39 /* libRNTrackPlayer.a in Frameworks */,
4080044209AE41A89AA5F5E1 /* libRNSentry.a in Frameworks */,
635C9ACE88614F23A21A1EB8 /* libz.tbd in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -882,6 +885,7 @@
TestTargetID = 13B07F861A680F5B00A75B9A;
};
13B07F861A680F5B00A75B9A = {
DevelopmentTeam = 4LTYKVQYZX;
LastSwiftMigration = 940;
SystemCapabilities = {
com.apple.BackgroundModes = {
Expand Down Expand Up @@ -1510,12 +1514,14 @@
CLANG_ENABLE_MODULES = YES;
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = NO;
DEVELOPMENT_TEAM = 4LTYKVQYZX;
HEADER_SEARCH_PATHS = (
"$(inherited)",
"$(SRCROOT)/../node_modules/react-native-music-control/ios",
"$(SRCROOT)/../node_modules/react-native-vector-icons/RNVectorIconsManager",
"$(SRCROOT)/../node_modules/react-native-video/ios",
"$(SRCROOT)/../node_modules/react-native-track-player/ios/RNTrackPlayer/**",
"$(SRCROOT)/../node_modules/react-native-sentry/ios/**",
);
INFOPLIST_FILE = quranicaudio/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
Expand All @@ -1525,6 +1531,7 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = com.app.quranicaudio;
PRODUCT_NAME = quranicaudio;
SWIFT_OBJC_BRIDGING_HEADER = "quranicaudio-Bridging-Header.h";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
Expand All @@ -1540,12 +1547,14 @@
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage;
CLANG_ENABLE_MODULES = YES;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_TEAM = 4LTYKVQYZX;
HEADER_SEARCH_PATHS = (
"$(inherited)",
"$(SRCROOT)/../node_modules/react-native-music-control/ios",
"$(SRCROOT)/../node_modules/react-native-vector-icons/RNVectorIconsManager",
"$(SRCROOT)/../node_modules/react-native-video/ios",
"$(SRCROOT)/../node_modules/react-native-track-player/ios/RNTrackPlayer/**",
"$(SRCROOT)/../node_modules/react-native-sentry/ios/**",
);
INFOPLIST_FILE = quranicaudio/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
Expand All @@ -1555,6 +1564,7 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = com.app.quranicaudio;
PRODUCT_NAME = quranicaudio;
SWIFT_OBJC_BRIDGING_HEADER = "quranicaudio-Bridging-Header.h";
SWIFT_VERSION = 3.0;
Expand Down
10 changes: 7 additions & 3 deletions ios/quranicaudio/AppDelegate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,13 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
{
NSURL *jsCodeLocation;

jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil];

RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
#ifdef DEBUG
jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index" fallbackResource:nil];
#else
jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
#endif

RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
moduleName:@"quranicaudio"
initialProperties:nil
launchOptions:launchOptions];
Expand Down
8 changes: 4 additions & 4 deletions ios/quranicaudio/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
<string>org.reactjs.native.example.$(PRODUCT_NAME:rfc1034identifier)</string>
<string>$(PRODUCT_BUNDLE_IDENTIFIER)</string>
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
Expand All @@ -21,9 +21,11 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1</string>
<string>4</string>
<key>LSRequiresIPhoneOS</key>
<true/>
<key>NSLocationWhenInUseUsageDescription</key>
<string/>
<key>NSAppTransportSecurity</key>
<dict>
<key>NSExceptionDomains</key>
Expand All @@ -35,8 +37,6 @@
</dict>
</dict>
</dict>
<key>NSLocationWhenInUseUsageDescription</key>
<string/>
<key>UIAppFonts</key>
<array>
<string>Entypo.ttf</string>
Expand Down
Loading