Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-legacy namespace package #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bertsky
Copy link

@bertsky bertsky commented May 24, 2024

The current legacy approach to namespace packaging does not work with development/editable installation. See OCR-D/ocrd_all#433

This PR fixes it for this package – analogous PRs to the other qurator repos will follow.

@mikegerber
Copy link
Member

I'd prefer getting rid of the qurator namespace instead - e.g. just using "sbb_images", not "qurator.sbb_images" here. There really is no benefit in sharing the namespace, just problems.

@mikegerber
Copy link
Member

(But it's up to @labusch and @cneud, just my opinion)

@bertsky
Copy link
Author

bertsky commented May 24, 2024

I'd prefer getting rid of the qurator namespace instead - e.g. just using "sbb_images", not "qurator.sbb_images" here. There really is no benefit in sharing the namespace, just problems.

IIUC these problems will be gone for good with the new-style namespace packaging. (But don't hold my feet to the fire for it.)

A pro argument is: under the qurator namespace, you have full control over interdependencies – no clashes due to package names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants