Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend methods for _FType and _CType #320

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Nov 22, 2024

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuantumToolbox.jl.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

This PR supports Complex{Int32} and Complex{Int64} for _FType and _CType.

@ytdHuang ytdHuang added the Skip ChangeLog Skip changelog update check in PR label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.55%. Comparing base (9d1cb6b) to head (4354d96).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/utilities.jl 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   93.21%   92.55%   -0.67%     
==========================================
  Files          36       36              
  Lines        2581     2578       -3     
==========================================
- Hits         2406     2386      -20     
- Misses        175      192      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@albertomercurio albertomercurio merged commit ab66af5 into main Nov 22, 2024
14 of 18 checks passed
@ytdHuang ytdHuang deleted the ytdHuang-patch-1 branch November 22, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip ChangeLog Skip changelog update check in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants