-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port single-photon-interference tutorial #79
Conversation
Thank you for your interest in contributing to qutip. Where does this example comes from? |
@Ericgig Thank you for the comment. It is one of the notebooks suggested to port (4th one) by @hodgestar in the issue #18 |
@Ericgig: This notebook was the result of an undergraduate student project that I supervised. |
@rochisha0 Thank you for opening the PR. It looks good, but there are a few things we need to sort out:
|
@hodgestar Thank you for the feedback. I have made the changes to the formatting style of the notebook. I hope it works. I will make the changes to the website template once we figure out a good folder name. |
@hodgestar How does physics tutorials sound for the folder name? |
@rochisha0 On second thoughts, let's stick with |
It looks like there is still one linting error:
|
@hodgestar Looks like there were some manual changes to be made regarding |
I can not trigger a workflow (guess I'm missing some permission). But I have checked your notebooks using @hodgestar I think this is ready for merging! :) |
Thanks @christian512. I don't know why the CI didn't run, but let me merge this and see what happens. |
@rochisha0 The ported tutorial is now published at http://qutip.org/qutip-tutorials/ -- thank you! I noticed that there are few minor things that need fixing on the published page that are related to this PR:
Would you be up to making a new PR to address these? |
@hodgestar Yes, I'll take this up. |
Thanks, @rochisha0! |
Pull Request Description
What does this PR do?
This PR ports a new tutorial on single photon interference for both v4 and v5
Related Issues: