Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to qwik 1.3.0 #540

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Updated to qwik 1.3.0 #540

merged 6 commits into from
Dec 8, 2023

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Dec 7, 2023

This fixes the tests issues and the ability to deploy the docs website

@shairez
Copy link
Contributor Author

shairez commented Dec 7, 2023

Hey @wmertens
I think your changes here QwikDev/qwik#5531 are breaking the build on this PR 😅

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Warnings
⚠️ ❗ Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR for faster, easier review.

Generated by 🚫 dangerJS against 8d1397b

@shairez
Copy link
Contributor Author

shairez commented Dec 7, 2023

@wmertens I fixed it

But I think it messed up the eslint rule, had to turn off qwik/valid-lexical-scope
Tried to write a failing test on Qwik core for it, but it didn't fail (which was weird)

If you turn it back on on Qwik UI you'll see the error when you try to lint headless

@shairez shairez merged commit 1d663c5 into main Dec 8, 2023
9 checks passed
@shairez shairez deleted the pr-qwik-1-3 branch December 8, 2023 00:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant