Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] Docs #118

Merged
merged 32 commits into from
Jun 19, 2024
Merged

[update] Docs #118

merged 32 commits into from
Jun 19, 2024

Conversation

StarTrooper08
Copy link
Collaborator

@StarTrooper08 StarTrooper08 commented May 31, 2024

Sorry, something went wrong.

Copy link
Member

@hturner hturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Copy link
Member

@hturner hturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the changes from 1050133 - the idea is that we consistently call it the R Dev Container, but the repo will still be called r-dev-env for now.

The screenshots need updating to match the new environment variable setting (i.e. BUILDDIR=/workspaces/r-dev-env/build/r-devel and TOP_SRCDIR=/workspaces/r-dev-env/svn/r-devel) - these affect the paths/variables that show in the terminal and the directories that appear in VSCode Explorer.

The screenshots also need updating in the R Contribution Workflow - pictures of the askYesNo code should not show linting problems as we are not using a linter.

Generally, it would be good to update the docs, then work through to ensure the screenshots match what the user will see with the latest container.

Copy link
Member

@hturner hturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed Building R section

@hturner hturner merged commit 11bf3b7 into devel Jun 19, 2024
@hturner hturner deleted the update/docs branch June 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants