-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[update] Docs #118
[update] Docs #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The final comment in New sections in docs #96 is not addressed: delete level 2 header and replace with level 1 header
# Useful Links
- The changes to wording in Missing Documentation Image #113 have not been addressed (https://via.hypothes.is/https://contributor.r-project.org/r-dev-env/tutorials/creating_codespace/)
- The changes to wording in Updates to R Contribution Workflow section #107 have not been addressed (https://via.hypothes.is/https://contributor.r-project.org/r-dev-env/tutorials/contribution_workflow/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you revert the changes from 1050133 - the idea is that we consistently call it the R Dev Container, but the repo will still be called r-dev-env for now.
The screenshots need updating to match the new environment variable setting (i.e. BUILDDIR=/workspaces/r-dev-env/build/r-devel and TOP_SRCDIR=/workspaces/r-dev-env/svn/r-devel) - these affect the paths/variables that show in the terminal and the directories that appear in VSCode Explorer.
The screenshots also need updating in the R Contribution Workflow - pictures of the askYesNo code should not show linting problems as we are not using a linter.
Generally, it would be good to update the docs, then work through to ensure the screenshots match what the user will see with the latest container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed Building R section
Merge branch 'devel' into update/docs # Conflicts: # docs/tutorials/multi_r_compilation.md
Work in Progress
Changes made