-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make $xml_find_function_calls() land on parent::expr instead #2715
Conversation
@AshesITR / @IndrajeetPatil PTAL at this today if you can. I need to submit an update to CRAN by tomorrow. If you prefer, I can just put a small patch on CRAN to meet the deadline & allow a little longer for review here. |
The change is okay for me on the grounds that we could remove many more Have you checked which of |
I'm 90% sure we've benchmarked |
Closes #2431.