Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace single quotes with escaped double quotes #306

Merged
merged 2 commits into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
* The generator of `compile_commands.json` is now more reliable in the presence
of extra whitespace in `make`'s output (#288, @TimTaylor).


* The generator of `compile_commands.json` now uses escaped double quotes for LinkingTo packages to ensure valid argument strings when parsed on Windows (#305, @tylermorganwall).

# pkgload 1.4.0

* The `reset` argment of `load_all()` is no longer supported because preserving
Expand Down
2 changes: 1 addition & 1 deletion R/compilation-db.R
Original file line number Diff line number Diff line change
Expand Up @@ -268,5 +268,5 @@
paths <- vapply(linking_to, function(pkg) system.file("include", package = pkg), "")
paths <- paths[paths != ""]

paste(paste0("-I'", paths, "'"), collapse = " ")
paste(paste0("-I\"", paths, "\""), collapse = " ")

Check warning on line 271 in R/compilation-db.R

View check run for this annotation

Codecov / codecov/patch

R/compilation-db.R#L271

Added line #L271 was not covered by tests
}