Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how MapKeys are handled #55

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fix how MapKeys are handled #55

merged 3 commits into from
Sep 13, 2024

Conversation

r0adkll
Copy link
Owner

@r0adkll r0adkll commented Sep 12, 2024

Fixed how Kimchi was handling map keys and added support for all possible annotation class parameter values and how they generate the binding under the hood.

Added new integration-test module for writing integration tests for testing the actual generated output from Kimchi and kotlin-inject. This was needed due to some bug in kotlin-compile-testing and kotlin-inject where it would throw NPE when processing multibinds with KClass key types.

Fixes #50

@r0adkll r0adkll self-assigned this Sep 12, 2024
Copy link

github-actions bot commented Sep 12, 2024

Warnings
⚠️ Big PR, try to keep changes smaller if you can
Messages
📖 This PR has been checked by Danger

Generated by 🚫 Danger Kotlin against 77bf512

@r0adkll r0adkll enabled auto-merge (squash) September 12, 2024 16:43
@r0adkll r0adkll merged commit 4bab568 into main Sep 13, 2024
4 checks passed
@r0adkll r0adkll deleted the dh/fix-map-key branch September 13, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapKey is broken
1 participant