Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin.compile.testing to v0.7.0 #87

Merged
merged 8 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@ captures
.cxx
local.properties
xcuserdata
kotlin-js-store
12 changes: 9 additions & 3 deletions Dangerfile.df.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,19 @@ danger(args) {
val sourceChanges = allSourceFiles.firstOrNull { it.contains("src") }
val testChanges = allSourceFiles.firstOrNull { it.contains("test") }

val isRenovatePr = git.commits.any { it.author.name.contains("renovate") }

onGitHub {
val isTrivial = pullRequest.title.contains("#trivial")

message("This PR has been checked by Danger")
if (isRenovatePr) {
message("Renovate PR - Ignoring checks")
} else {
message("This PR has been checked by Danger")
}

// Changelog
if (!isTrivial && !changelogChanged) {
if (!isTrivial && !isRenovatePr && !changelogChanged) {
fail(
"any changes to library code should be reflected in the Changelog.\n\n" +
"Please add your change there and adhere to the " +
Expand All @@ -24,7 +30,7 @@ danger(args) {
}

// Testing
if (sourceChanges != null && testChanges == null) {
if (!isRenovatePr && sourceChanges != null && testChanges == null) {
fail("any changes to library code should have accompanied tests. Please add tests to cover your changes.")
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,11 @@ data class MapKeyValue(private val valueArgument: KSValueArgument) {
)

val format = when (value) {
is Long -> "%LL"

is Byte,
is Short,
is Int,
is Long,
is Float,
is Double,
is Boolean,
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ compose-multiplatform = "1.7.1"
dokka = "2.0.0"
junit5 = "5.11.4"
kotlin = "2.1.0"
kotlin-compile-testing = "0.6.0"
kotlin-compile-testing = "0.7.0"
kotlin-inject = "0.7.2"
kotlinpoet = "2.0.0"
ksp = "2.1.0-1.0.29"
Expand Down
Loading
Loading