Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to fetch inbound_hash value from email.to property #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

query-string
Copy link

It might be helpful for cases when Postmark's Inbound Domain Forwarding has been configured and something meaningful precedes inbound domain name. For example, I use it for defining publication level and messages from inbound email [email protected] go private.

@r38y
Copy link
Owner

r38y commented Dec 12, 2016

Hey, thanks for the PR! I'm a little hesitant to pull this in because I think it's something that should be done at the application layer since it's kind of interpreting the data that comes from Postmark. This gem just kind of maps the fields.

I've been recommending people use

https://github.com/thoughtbot/griddler
https://github.com/r38y/griddler-postmark

@query-string
Copy link
Author

Hey Randy! Thanks for recommendations – I haven't noticed ABANDONWARE warning in the README file )

@r38y
Copy link
Owner

r38y commented Dec 13, 2016

It's not quite abandonware, we're still heavily dependent on it at my current company and if we see something that needs to change and fits what this gem does (basically maps fields), we add or fix it. But I'm also migrating us away from it right now.

That being said, this gem is really just mapping json to prettier method names and I'm not sure this diff fits in with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants