Merge pull request #570 from ra3xdh/fix_562

Fixes tuner crash #562
ra3xdh · Feb 16, 2024 · bdc143e · bdc143e
2 parents afe87e7 + a5f87d2
commit bdc143e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/qucs/dialogs/tuner.cpp b/qucs/dialogs/tuner.cpp
@@ -265,7 +265,7 @@ void tunerElement::resetValue()
     value->setText(val);
     ValueUnitsCombobox->setCurrentIndex(index);
     updateSlider();
-    slotValueChanged();
+    slotValueChanged(false);
 }
 
 /*
@@ -462,7 +462,7 @@ void tunerElement::slotSliderChanged()
  * The control reaches this function when one of the events above is triggered. It checks if the input value is correct, updates it
  * and finally runs the simulation
  */
-void tunerElement::slotValueChanged()
+void tunerElement::slotValueChanged(bool simulate)
 {
     bool ok;
     float v = getValue(ok);
@@ -501,7 +501,9 @@ void tunerElement::slotValueChanged()
 
     updateSlider();
     updateProperty();
-    emit elementValueUpdated();
+    if (simulate) {
+        emit elementValueUpdated();
+    }
     value->blockSignals(false);
     ValueUnitsCombobox->blockSignals(false);
 }
@@ -803,6 +805,7 @@ void TunerDialog::slotResetValues()
     {
         currentElements.at(i)->resetValue();
     }
+    slotElementValueUpdated();
 }
 
 void TunerDialog::slotUpdateValues()

diff --git a/qucs/dialogs/tuner.h b/qucs/dialogs/tuner.h
@@ -97,7 +97,7 @@ class tunerElement : public QWidget
         void slotMinValueChanged();
         void slotMaxValueChanged();
         void slotStepChanged();
-        void slotValueChanged();
+        void slotValueChanged(bool simulate = true);
         void slotDelete();
         void slotDownClicked();
         void slotUpClicked();