Dev/tze/feature export cdl netlist #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 23, 2024 11:12
-introduced new parameter for cdl-type netlist export to Component::spice_netlist and all derivatives under components/ Signed-off-by: ThomasZecha <[email protected]>
-introduced new parameter for cdl-type netlist export to Component::spice_netlist derivatives under spicecomponents/ Signed-off-by: ThomasZecha <[email protected]>
-Added cdl_netlist() as default to class Component and as implementation to CDL supporting derived components. Besides some port-number checking this implementation is a wrapper for spice_netlist. -Implemented necessary spice_netlist() adjustments to meet CDL requirements. -Improved spice_netlist() derived default parameter 'isXyce' to be explicitly set. -Fixed using of tabs/trailing spaces. Signed-off-by: ThomasZecha <[email protected]>
-Introduced new parameter for cdl-type netlist export to Component::getExpression() and derivatives. It is used for CDL type specific netlist parameter export. Signed-off-by: ThomasZecha <[email protected]>
-Changed Schematic::giveNodeNames() to public to be usable from new class CdlNetlistWriter -Changed AbstractSpiceKernel::collectSpiceLibs() to public static since it don't use any instance member and to be usable from new class CdlNetlistWriter -Added new class CdlNetlistWriter implementing CDL netlist export Signed-off-by: ThomasZecha <[email protected]>
-integrated CdlNetlistWriter in application GUI Signed-off-by: ThomasZecha <[email protected]>
-Fixed compiler warnings regarding missing virtual destructor Signed-off-by: ThomasZecha <[email protected]>
-Fixed wrong usage of Q_ASSERT testing connect() result Signed-off-by: ThomasZecha <[email protected]>
|
It may be better to keep this PR open, but marking this as WIP to prevent merging by accident. This will allow to test mergeabity and apply CI. Considering this PR I have noticed that you have introduced The |
|
Re-worked according to comments, dev-branch pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.