Port away from deprecated Qt6 methods and constuctors #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra3xdh
reviewed
Nov 23, 2023
| @@ -371,8 +371,8 @@ void ImageWriter::getSelAreaWidthAndHeight(Schematic *sch, int &wsel, int &hsel, | |||
| pd->Bounding(x1,y1,x2,y2); | |||
| updateMinMax(xmin,xmax,ymin,ymax,x1,x2,y1,y2); | |||
|
|
|||
| for (auto& pg: qAsConst(pd->Graphs)) { | |||
| for (auto& pm: qAsConst(pg->Markers)) { | |||
| for (auto& pg: std::as_const(pd->Graphs)) { | |||
There was a problem hiding this comment.
Need to check if as_const supported by GCC9 from Ubuntu-20.04. This distribution have to be supported.
There was a problem hiding this comment.
IMHO
- we just need to remove the function qAsConst and use C++ 11 (there are many places in qucs where Graphs iterated without qAsConst)
- for setNamedColor we can write single utility function with conditional compilation and use it everywhere instead off many
#if QT_VERSION >= QT_VERSION_CHECK(6, 4, 0)
There was a problem hiding this comment.
Yes, the wrapper macro or function for setNamedColor() will be better solution. We can put it somewhere in misc.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375 (part 2)