Modify SPICE RCD devices; fixes #349 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks impressive, thanks for the contribution! There is a typo in DIODE_SPICE.cpp See my line comment. |
It makes sense to add a new group named "PDK devices" or something similar and put 3-pin devices (with substrate) in this group. |
4 tasks
|
In addition to Resistor, Capacitor, and Diode, I've also moved the previously added BJT and MOS devices. I chose not to include all possible variations of elements in the 'PDK devices' group, as it was done for MOS transistors. |
ra3xdh
approved these changes
Jan 4, 2024
Radvall
force-pushed
the
modify_spice_devices
branch
from
e88773b to
0dac9b3
Compare
|
Thanks for the contribution! Merged. |
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added X letter and pin-number proprieties to the existing R_SPICE, C_SPICE and DIODE_SPICE devices, placing them at the end of the proprieties list. This should not affect compatibility with older schematic versions. The new symbols are shown bellow:
I turned off rotation for R_SPICE and C_SPICE components as this fix the selection box during editing when clicking apply and when inserting a component after CTR+C CTR+V.
Also I added 3-pin symbols to the left panel but I'm not sure if they are needed there.